Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing(cloud): remove missing Makefile target dep #14523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

testing(cloud): remove missing Makefile target dep #14523

wants to merge 1 commit into from
+3 −3

Conversation

inge4pres
Copy link
Contributor

Motivation/summary

While investigating an issue, I found out a couple of problems in the testing setup.

How to test these changes

cd testing/cloud
make docker_image.auto.tfvars
make apply

Before this PR, this would throw an error on a missing dependency.

Then clean it up

make destroy

@inge4pres inge4pres added the test label Nov 4, 2024
@inge4pres inge4pres requested a review from a team as a code owner November 4, 2024 14:16
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pkg 1pkg 1pkg approved these changes

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inge4pres @1pkg